]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
[appDisplay] Always relaunch application on drag and drop
authorColin Walters <walters@verbum.org>
Fri, 21 Aug 2009 00:03:28 +0000 (20:03 -0400)
committerColin Walters <walters@verbum.org>
Fri, 21 Aug 2009 00:03:28 +0000 (20:03 -0400)
Rather than just launching if we weren't already running, always
relaunch, which happens to make Firefox, etc. work.  See
the comment in the commit for more explanation.

js/ui/appDisplay.js

index dcd61524f01937efb86edbee0a471d3a89054c10..7930f5d720f37ba94424878889dbe0fcc0ced98b 100644 (file)
@@ -540,12 +540,15 @@ WellDisplayItem.prototype = {
     },
 
     shellWorkspaceLaunch : function() {
-        if (this._windows.length == 0) {
-            this.appInfo.launch();
-        } else {
-            // We should open a new window for the app here, once we know
-            // how to do that.
-        }
+        // Here we just always launch the application again, even if we know
+        // it was already running.  For most applications this
+        // should have the effect of creating a new window, whether that's
+        // a second process (in the case of Calculator) or IPC to existing
+        // instance (Firefox).  There are a few less-sensical cases such
+        // as say Pidgin, but ideally what we do there is have the app
+        // express to us that it doesn't do relaunch=new-window in the
+        // .desktop file.
+        this.appInfo.launch();
     },
 
     getDragActor: function(stageX, stageY) {